https://gitlab.synchro.net/main/sbbs/-/commit/1bac2b62ef23ae473cb4622c
Modified Files:
src/syncterm/ssh.c
Log Message:
Fix sourceforge issue 136

With ssh_sock initialized to zero, if the connect fails, stdin was
closed, preventing ANSI and curses modes from functioning.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/8bc6f5f864e69b8d3c1f5680
Modified Files:
src/syncterm/ssh.c
Log Message:
Some more ssh_close() cleanup

Make ssh_active only true when ssh_session was set.
Only do ssh cleanup if ssh_active is true.
Initialize channel values to -1 (already done in ssh_connect(), but
doesn't hurt anything).

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/3d425a47316e605164f7b3e5
Modified Files:
src/syncterm/ssh.c
Log Message:
Be sure to close ssh_sock regardless of ssh_active

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/69c11e5072818e18aeb38f5e
Modified Files:
src/syncterm/ssh.c
Log Message:
Destroy ssh_tx_mutex

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/5508a8a558058fcaeb356242
Modified Files:
src/syncterm/ssh.c
Log Message:
No no, *DESTROY* sftp_tx_mutex

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/e15ba30749ace18e46675ec4
Modified Files:
src/syncterm/ssh.c
Log Message:
Move ssh_complete out of ssh_mutex

Coverity seems to hate it mostly in the mutex, so change it to
mostly outside of the mutex and see if that's fine.

It doesn't really matter where it's changed as it's an atomic bool.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/1326b624bd973b8e3f6e9b93
Modified Files:
src/syncterm/ssh.c
Log Message:
Fix memory leak when connection lost during SFTP key check

Found by scan-build

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/ee15f3cfe79bf6f5f0486f3e
Modified Files:
src/syncterm/ssh.c
Log Message:
Remove more redundant code

ssh_active was never set to false anymore
channel_gone did exactly the same thing as conn_api.terminate
change read/write timeouts to zero when closing

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ad896e3b34767ba64207875
Modified Files:
src/syncterm/ssh.c
Log Message:
Remove likely obsolete Coverity suppression.

It can be added back if the issue reappears.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/772609493c77c12dcadf8bc4
Modified Files:
src/syncterm/ssh.c
Log Message:
assert() ssh globals are initialized correctly.

Some weren't (mostly sftp ones though)

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

https://gitlab.synchro.net/main/sbbs/-/commit/0ff6b5ecb393dcf2f170f68e
Modified Files:
src/syncterm/ssh.c
Log Message:
Re-add coverity suppression. Not obsolete.

---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net